point to @webxdc/types and use @webxdc/vite-plugins for emulator#61
point to @webxdc/types and use @webxdc/vite-plugins for emulator#61
@webxdc/types and use @webxdc/vite-plugins for emulator#61Conversation
adbenitez
force-pushed
the
adb/point-to-webxdc-types-and-emulator
branch
from
d7d3831 to
e4f6c48
Compare
Simon-Laux
left a comment
Simon-Laux
left a comment
There was a problem hiding this comment.
Looks good to me, but let's wait for @r10s' approval
There was a problem hiding this comment.
first of all, thanks a lot for the cleanup of the other repo!
for webxdc.js on some CDN:
i understand, why we do not want to copy the file, wrt maintenance etc.
however, by pulling a file from some CDN, the magic of simplicity and understanding things when not deep into js is also gone somehow, at least for ppl as me.
when following the instructions, you will also have https://cdn.jsdelivr.net/gh/webxdc/vite-plugins@latest/src/webxdc.js forever in your source code ...
and these instructions are also not what we're saying at https://webxdc.org/docs/#a-simple-example
and having two webxdc.js in the code is also a bit weird.
so, regarding the fact that webxdc.js is not changed that often, maybe it is better to stay with a copy.
| <script src="https://cdn.jsdelivr.net/gh/webxdc/vite-plugins@latest/src/webxdc.js"></script> | ||
| <script src="webxdc.js"></script> |
There was a problem hiding this comment.
so, that results to one 404 in all cases?
There was a problem hiding this comment.
one of them will always succeed, if you are in DC the real thing will load while in the browser the emulator is used
that is not a problem since it just silently fails to load inside DC where the app doesn't have internet
at the same time now it is easier for people that don't have experience with git, they can just download the index.html file and just with that file alone or copying the content of the example index.html can get it to work |
|
There is also an unrelated |
4 participants
close #51